Issue 10878042: Propagate type of list literal from parser to ast, graph, and optimizer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10878042: Propagate type of list literal from parser to ast, graph, and optimizer. (Closed)

Created:
8 years, 4 months ago by regis

Modified:
8 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Propagate type of list literal from parser to ast, graph, and optimizer. Committed: https://code.google.com/p/dart/source/detail?r=11329

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -18 lines)			Patch
M	runtime/vm/ast.h	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	4 chunks	+9 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	4 chunks	+15 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10878042/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://chromiumcodereview.appspot.com/10878042/diff/1/runtime/vm/object.cc#newcode771 runtime/vm/object.cc:771: pending_classes.Add(cls, Heap::kOld); Since numer is an interface, shouldn't ...

8 years, 4 months ago (2012-08-24 17:08:33 UTC) #2

regis

8 years, 4 months ago (2012-08-24 18:16:02 UTC) #3

Thanks

https://chromiumcodereview.appspot.com/10878042/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/10878042/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:771: pending_classes.Add(cls, Heap::kOld);
On 2012/08/24 17:08:33, srdjan wrote:
> Since numer is an interface, shouldn't we be using CreateAndRegisterInterface
> instead?

I understand we are transitioning to an interface-less world. Function and
Number were converted a couple of days ago.

Expand Messages | Collapse Messages

Issue 10878042: Propagate type of list literal from parser to ast, graph, and optimizer. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages