Issue 10878037: - GET_NATIVE_ARGUMENT uses the isolate which is passed in to allocate the handle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10878037: - GET_NATIVE_ARGUMENT uses the isolate which is passed in to allocate the handle. (Closed)

Created:
8 years, 4 months ago by Ivan Posva

Modified:
8 years, 4 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- GET_NATIVE_ARGUMENT uses the isolate which is passed in to allocate the handle. - Avoid frequent calls to Isolate::Current(). - Avoid handle allocation in a loop for StringBase.createFromCodepoints. - Avoid copying in StringBase._interpolate. Committed: https://code.google.com/p/dart/source/detail?r=11279

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -25 lines)			Patch
M	runtime/lib/string.cc	View	3 chunks	+6 lines, -7 lines	0 comments	Download
M	runtime/lib/string.dart	View	1 chunk	+3 lines, -15 lines	0 comments	Download
M	runtime/vm/native_entry.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/raw_object.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages