Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 10878010: Restore js interop code (Closed)

Created:
8 years, 4 months ago by vsm
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Restore js interop code Create a copy of the formerly shared serialization code for now to unblock js interop work. We can discuss if/how it makes sense to merge these. Committed: https://code.google.com/p/dart/source/detail?r=11171

Patch Set 1 #

Patch Set 2 : Remove old serialization file #

Patch Set 3 : Restore js function passing code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1455 lines, -25 lines) Patch
lib/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
lib/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +2 lines, -1 line 0 comments Download
lib/html/dart2js/html_dart2js.dart View 2 chunks +479 lines, -0 lines 0 comments Download
lib/html/dartium/html_dartium.dart View 2 chunks +494 lines, -15 lines 0 comments Download
lib/html/src/Isolates.dart View 1 chunk +266 lines, -0 lines 0 comments Download
lib/html/src/Serialization.dart View 1 chunk +213 lines, -0 lines 0 comments Download
tests/html/html.status View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
8 years, 4 months ago (2012-08-22 15:32:51 UTC) #1
Anton Muhin
diff might be slightly off, but LGTM anyway
8 years, 4 months ago (2012-08-22 15:45:23 UTC) #2
vsm
8 years, 4 months ago (2012-08-22 16:36:26 UTC) #3
On 2012/08/22 15:45:23, Anton Muhin wrote:
> diff might be slightly off, but LGTM anyway

Thanks.  Cleaned up a bit more and landed.

Powered by Google App Engine
This is Rietveld 408576698