Issue 10878006: Re-introduce the _dispatchEvent function in lib/html/src/Isolates.dart.

Issue 10878006: Re-introduce the _dispatchEvent function in lib/html/src/Isolates.dart. (Closed)

Created:
8 years, 4 months ago by Anders Johnsen

Modified:
8 years, 4 months ago

Reviewers:
Mads Ager (google), kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Re-introduce the _dispatchEvent function in lib/html/src/Isolates.dart. Removed by accident. BUG= Committed: https://code.google.com/p/dart/source/detail?r=11134

Patch Set 1 #

Total comments: 3

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -0 lines)			Patch
M	lib/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/dom/templates/html/dartium/html_dartium.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/html/dart2js/html_dart2js.dart	View	1 chunk	+9 lines, -0 lines	1 comment	Download
M	lib/html/dartium/html_dartium.dart	View	1 chunk	+9 lines, -0 lines	2 comments	Download
A	lib/html/src/Isolates.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM https://chromiumcodereview.appspot.com/10878006/diff/1/lib/html/dart2js/html_dart2js.dart File lib/html/dart2js/html_dart2js.dart (right): https://chromiumcodereview.appspot.com/10878006/diff/1/lib/html/dart2js/html_dart2js.dart#newcode37102 lib/html/dart2js/html_dart2js.dart:37102: +// Copyright (c) 2012, the Dart project authors. ...

8 years, 4 months ago (2012-08-22 11:57:41 UTC) #3

Anders Johnsen

8 years, 4 months ago (2012-08-22 11:59:15 UTC) #4

https://chromiumcodereview.appspot.com/10878006/diff/1/lib/html/dartium/html_...
File lib/html/dartium/html_dartium.dart (right):

https://chromiumcodereview.appspot.com/10878006/diff/1/lib/html/dartium/html_...
lib/html/dartium/html_dartium.dart:40744: +// Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
On 2012/08/22 11:57:41, Mads Ager wrote:
> Ditto, autogenerated files?

Yep, autogenerated.

Expand Messages | Collapse Messages