Issue 10877030: Fix inlining and intrinsification for moved Math methods.

Issue 10877030: Fix inlining and intrinsification for moved Math methods. (Closed)

Created:
8 years, 4 months ago by srdjan

Modified:
8 years, 4 months ago

Reviewers:
regis, siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix inlining and intrinsification for moved Math methods. Committed: https://code.google.com/p/dart/source/detail?r=11201

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intrinsifier.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/10877030/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://chromiumcodereview.appspot.com/10877030/diff/1/runtime/vm/intermediate_language.cc#newcode154 runtime/vm/intermediate_language.cc:154: // Only core library methods can be recognized. ...

8 years, 4 months ago (2012-08-23 01:08:37 UTC) #3

srdjan

8 years, 4 months ago (2012-08-23 01:10:46 UTC) #4

https://chromiumcodereview.appspot.com/10877030/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.cc (right):

https://chromiumcodereview.appspot.com/10877030/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.cc:154: // Only core library methods can be
recognized.
On 2012/08/23 01:08:37, asiva wrote:
> update comment for math library as well.

Done.

https://chromiumcodereview.appspot.com/10877030/diff/1/runtime/vm/intrinsifie...
File runtime/vm/intrinsifier.cc (right):

https://chromiumcodereview.appspot.com/10877030/diff/1/runtime/vm/intrinsifie...
runtime/vm/intrinsifier.cc:58: // Only core library methods can be intrinsified.
On 2012/08/23 01:08:37, asiva wrote:
> Ditto.

Done.

Expand Messages | Collapse Messages