Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 10877024: Add support for the metadata we currently support in comments (Closed)

Created:
8 years, 4 months ago by Brian Wilkerson
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add support for the metadata we currently support in comments Committed: https://code.google.com/p/dart/source/detail?r=11230

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A pkg/meta/meta.dart View 1 chunk +34 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Brian Wilkerson
We (the editor team) would like to add a library to contain the definition of ...
8 years, 4 months ago (2012-08-22 20:28:54 UTC) #1
Bob Nystrom
LGTM. It would be nice if there was an annotation to annotate that a constant ...
8 years, 4 months ago (2012-08-22 20:41:57 UTC) #2
Brian Wilkerson
> It would be nice if there was an annotation to annotate that a constant ...
8 years, 4 months ago (2012-08-22 21:16:01 UTC) #3
devoncarew
lgtm
8 years, 4 months ago (2012-08-22 22:45:32 UTC) #4
dgrove
lgtm
8 years, 4 months ago (2012-08-23 00:25:34 UTC) #5
Brian Wilkerson
8 years, 4 months ago (2012-08-23 14:52:51 UTC) #6
http://codereview.chromium.org/10877024/diff/1/pkg/meta/meta.dart
File pkg/meta/meta.dart (right):

http://codereview.chromium.org/10877024/diff/1/pkg/meta/meta.dart#newcode26
pkg/meta/meta.dart:26: * setter) as one that is intended to be overriding an
inherited class member.
Done.

Powered by Google App Engine
This is Rietveld 408576698