Issue 10877011: Do not clear the spill slots in optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10877011: Do not clear the spill slots in optimized code. (Closed)

Created:
8 years, 4 months ago by Kevin Millikin (Google)

Modified:
8 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Do not clear the spill slots in optimized code. Also, change all calls in the prologue to have a stackmap. R=vegorov@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11215

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -40 lines)			Patch
	M	runtime/vm/flow_graph_compiler_ia32.cc	View		7 chunks	+27 lines, -20 lines	1 comment	Download
	M	runtime/vm/flow_graph_compiler_x64.cc	View		7 chunks	+27 lines, -20 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

8 years, 4 months ago (2012-08-22 13:22:08 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10877011/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://chromiumcodereview.appspot.com/10877011/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_compiler_ia32.cc:954: __ Comment("Initialize spill
slots");
"Initialize locals"

https://chromiumcodereview.appspot.com/10877011/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_compiler_x64.cc (right):

https://chromiumcodereview.appspot.com/10877011/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_compiler_x64.cc:961: __ Comment("Initialize spill slots");
Initialize locals

Expand Messages | Collapse Messages