Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 10877010: Update status file to use mac instead of macos. (Closed)

Created:
8 years, 4 months ago by ricow1
Modified:
8 years, 4 months ago
Reviewers:
ahe, Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update status file to use mac instead of macos. Emily: why do we have these skip exceptions anyway, imho they don't make any sense at all (who has ie on linux or mac?). If there is no deeper meaning we should delete them. Committed: https://code.google.com/p/dart/source/detail?r=11287

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tests/benchmark_smoke/benchmark_smoke.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/corelib.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/json/json.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
8 years, 4 months ago (2012-08-22 10:52:24 UTC) #1
ahe
LGTM! What if test.dart knew that ie/macos or ie/linux doesn't make sense. Just like when ...
8 years, 4 months ago (2012-08-22 11:17:22 UTC) #2
ricow1
On 2012/08/22 11:17:22, ahe wrote: > LGTM! > > What if test.dart knew that ie/macos ...
8 years, 4 months ago (2012-08-22 11:21:52 UTC) #3
Emily Fortuna
8 years, 4 months ago (2012-08-22 18:06:57 UTC) #4
lgtm
The skip sections are just to prevent someone from running tests with that
combo, which you're right: it doesn't make much sense. @Peter--test.dart already
does some "validation" of combinations that "make sense" (ie, you can't have
compiler=none and runtime=safari), so we could certainly add the (no ie on mac
or linux). The one where it's actually still useful to have I think is there is
a Safari for Windows, so we should still explicitly have that skip.

Powered by Google App Engine
This is Rietveld 408576698