Issue 10877009: Remove the shared js_isolate_impl and the current js/dart interop implementation.

Issue 10877009: Remove the shared js_isolate_impl and the current js/dart interop implementation. (Closed)

Created:
8 years, 4 months ago by Anders Johnsen

Modified:
8 years, 4 months ago

Reviewers:
Mads Ager (google), kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove the shared js_isolate_impl and the current js/dart interop implementation. The implementation dependent on the private implementation implementation of isolates in of dart2js. The tests have been marked as Fail for now. BUG= Committed: https://code.google.com/p/dart/source/detail?r=11133

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add issue to test status comment. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+212 lines, -1471 lines)			Patch
M	lib/compiler/implementation/lib/isolate_patch.dart	View		2 chunks	+207 lines, -3 lines	0 comments	Download
M	lib/dom/templates/html/dart2js/html_dart2js.darttemplate	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	lib/dom/templates/html/dartium/html_dartium.darttemplate	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	lib/html/dart2js/html_dart2js.dart	View		2 chunks	+0 lines, -488 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		2 chunks	+0 lines, -488 lines	0 comments	Download
D	lib/html/src/Isolates.dart	View		1 chunk	+0 lines, -275 lines	0 comments	Download
D	lib/js_isolate_impl/isolate.dart	View		1 chunk	+0 lines, -213 lines	0 comments	Download
M	tests/html/html.status	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM https://chromiumcodereview.appspot.com/10877009/diff/1/tests/html/html.status File tests/html/html.status (right): https://chromiumcodereview.appspot.com/10877009/diff/1/tests/html/html.status#newcode11 tests/html/html.status:11: # Isloate implementation is private after the unification. ...

8 years, 4 months ago (2012-08-22 10:30:59 UTC) #2

kasperl

LGTM. Vijay is the king of the JS interop, so CC'ing him on the bug ...

8 years, 4 months ago (2012-08-22 11:21:05 UTC) #3

Anders Johnsen

Thanks, landed. https://chromiumcodereview.appspot.com/10877009/diff/1/tests/html/html.status File tests/html/html.status (right): https://chromiumcodereview.appspot.com/10877009/diff/1/tests/html/html.status#newcode11 tests/html/html.status:11: # Isloate implementation is private after the ...

8 years, 4 months ago (2012-08-22 11:24:30 UTC) #4

vsm

8 years, 4 months ago (2012-08-22 15:16:57 UTC) #5

Can you guys give me some insight into why this was landed?  I don't see any
dependences on internal dart2js code besides what was already copied out to
lib/js_isolate_impl/isolate.dart.

I'd rather duplicate that file instead of tearing all this out and disabling the
corresponding tests.

On 2012/08/22 11:24:30, ajohnsen wrote:
> Thanks, landed.
> 
> https://chromiumcodereview.appspot.com/10877009/diff/1/tests/html/html.status
> File tests/html/html.status (right):
> 
>
https://chromiumcodereview.appspot.com/10877009/diff/1/tests/html/html.status...
> tests/html/html.status:11: # Isloate implementation is private after the
> unification.
> On 2012/08/22 10:30:59, Mads Ager wrote:
> > Isloate -> Isolate
> > 
> > Please file a bug that the js interop based on internals of the isolate
> library
> > is now broken so we can track this.
> 
> Done.

Expand Messages | Collapse Messages