Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 10876100: Convert double interface into abstract class (Closed)

Created:
8 years, 3 months ago by hausner
Modified:
8 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, kasperl
Visibility:
Public.

Description

Convert double interface into abstract class In a future change, we can implement double in the core library, eliminating class Double (using the patch class feature). Committed: https://code.google.com/p/dart/source/detail?r=11631

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -58 lines) Patch
M lib/core/double.dart View 1 2 1 chunk +18 lines, -14 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 1 2 3 chunks +17 lines, -9 lines 0 comments Download
M runtime/vm/dart_api_message.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 1 2 4 chunks +8 lines, -10 lines 0 comments Download
M runtime/vm/object_store.h View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/object_store.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/snapshot.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/snapshot_ids.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
8 years, 3 months ago (2012-08-28 01:20:53 UTC) #1
siva
lgtm https://chromiumcodereview.appspot.com/10876100/diff/1/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://chromiumcodereview.appspot.com/10876100/diff/1/runtime/vm/class_finalizer.cc#newcode306 runtime/vm/class_finalizer.cc:306: } I presume this is tied to the ...
8 years, 3 months ago (2012-08-29 23:49:36 UTC) #2
hausner
8 years, 3 months ago (2012-08-30 17:32:14 UTC) #3
Thank you.

Powered by Google App Engine
This is Rietveld 408576698