Issue 10876084: Cache function proxies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10876084: Cache function proxies (Closed)

Created:
8 years, 3 months ago by vsm

Modified:
8 years, 3 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cache function proxies. This ensures that we forward invocations to the original send port. Committed: https://code.google.com/p/dart/source/detail?r=11410

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Add better comments #

Total comments: 2

Patch Set 4 : Regen dart:html #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -11 lines)			Patch
M	client/dart.js	View	1 2	6 chunks	+22 lines, -8 lines	0 comments	Download
M	lib/html/dart2js/html_dart2js.dart	View		4 chunks	+42 lines, -1 line	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		4 chunks	+42 lines, -1 line	0 comments	Download
M	lib/html/src/Isolates.dart	View	1 2 3	4 chunks	+42 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

8 years, 3 months ago (2012-08-27 20:10:39 UTC) #2

lgtm!

https://chromiumcodereview.appspot.com/10876084/diff/1005/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10876084/diff/1005/client/dart.js#newc...
client/dart.js:90: // function, use a cached value.
nice.

https://chromiumcodereview.appspot.com/10876084/diff/1005/lib/html/src/Isolat...
File lib/html/src/Isolates.dart (right):

https://chromiumcodereview.appspot.com/10876084/diff/1005/lib/html/src/Isolat...
lib/html/src/Isolates.dart:183: // hashable.
:-)

Expand Messages | Collapse Messages