Issue 10876079: Clean up LoadInstanceField and StoreInstanceField.

Issue 10876079: Clean up LoadInstanceField and StoreInstanceField. (Closed)

Created:
8 years, 3 months ago by Florian Schneider

Modified:
8 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Clean up LoadInstanceField and StoreInstanceField. Since we have explicit class-id checks, I removed the now unused code that emitted the checks as part of the instruction. Committed: https://code.google.com/p/dart/source/detail?r=11383

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -99 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		5 chunks	+7 lines, -16 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	5 chunks	+2 lines, -38 lines	1 comment	Download
M	runtime/vm/intermediate_language_x64.cc	View		5 chunks	+2 lines, -38 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://chromiumcodereview.appspot.com/10876079/diff/2002/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://chromiumcodereview.appspot.com/10876079/diff/2002/runtime/vm/intermediate_language_ia32.cc#newcode949 runtime/vm/intermediate_language_ia32.cc:949: void LoadInstanceFieldComp::EmitNativeCode(FlowGraphCompiler* compiler) { I think Load|StoreInstanceFieldComp and ...

8 years, 3 months ago (2012-08-27 13:37:50 UTC) #2

Florian Schneider

8 years, 3 months ago (2012-08-27 13:52:37 UTC) #3

On 2012/08/27 13:37:50, Vyacheslav Egorov (Google) wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/10876079/diff/2002/runtime/vm/intermed...
> File runtime/vm/intermediate_language_ia32.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10876079/diff/2002/runtime/vm/intermed...
> runtime/vm/intermediate_language_ia32.cc:949: void
> LoadInstanceFieldComp::EmitNativeCode(FlowGraphCompiler* compiler) {
> I think Load|StoreInstanceFieldComp and Load|StoreVMField should be unified
> because they all boil down to a move with some FieldAddress(instance, offset).

Yes, there is quite a lot of duplicated code there. I'll clean that up in a
separate CL.

Expand Messages | Collapse Messages