Issue 10876058: Split pub tests into separate suites.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10876058: Split pub tests into separate suites. (Closed)

Created:
8 years, 4 months ago by Bob Nystrom

Modified:
8 years, 4 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org, siva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Split pub tests into separate suites. Committed: https://code.google.com/p/dart/source/detail?r=11283

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+818 lines, -795 lines)			Patch
A	utils/tests/pub/pub_install_git_test.dart	View	1 chunk	+313 lines, -0 lines	0 comments	Download
A	utils/tests/pub/pub_install_repo_test.dart	View	1 chunk	+232 lines, -0 lines	0 comments	Download
A	utils/tests/pub/pub_install_sdk_test.dart	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	utils/tests/pub/pub_test.dart	View	1 chunk	+0 lines, -795 lines	0 comments	Download
A	utils/tests/pub/pub_update_git_test.dart	View	1 chunk	+163 lines, -0 lines	0 comments	Download
A	utils/tests/pub/pub_update_repo_test.dart	View	1 chunk	+78 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

This should address timeout problems on the test suite.

8 years, 4 months ago (2012-08-24 01:23:15 UTC) #1

nweiz

LGTM Where do you envision the tests in https://chromiumcodereview.appspot.com/10874051/ belonging in this new scheme?

8 years, 4 months ago (2012-08-24 01:25:40 UTC) #2

Bob Nystrom

8 years, 4 months ago (2012-08-24 01:42:45 UTC) #3

On 2012/08/24 01:25:40, nweiz wrote:
> LGTM
> 
> Where do you envision the tests in
> https://chromiumcodereview.appspot.com/10874051/ belonging in this new scheme?

I'd probably just make a separate pub_install_test.dart suite that's not source
specific.

Expand Messages | Collapse Messages