Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 10876045: update library mapping (Closed)

Created:
8 years, 4 months ago by danrubel
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

update library mapping Committed: https://code.google.com/p/dart/source/detail?r=11339

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -15 lines) Patch
M lib/_internal/libraries.dart View 1 7 chunks +47 lines, -15 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
danrubel
* add platforms * change internal --> documented
8 years, 4 months ago (2012-08-23 17:48:32 UTC) #1
keertip
lgtm https://chromiumcodereview.appspot.com/10876045/diff/1/lib/_internal/libraries.dart File lib/_internal/libraries.dart (right): https://chromiumcodereview.appspot.com/10876045/diff/1/lib/_internal/libraries.dart#newcode84 lib/_internal/libraries.dart:84: platforms: VM_PLATFORM), Add documented: false? Currently file shows ...
8 years, 4 months ago (2012-08-23 18:03:11 UTC) #2
danrubel
https://chromiumcodereview.appspot.com/10876045/diff/1/lib/_internal/libraries.dart File lib/_internal/libraries.dart (right): https://chromiumcodereview.appspot.com/10876045/diff/1/lib/_internal/libraries.dart#newcode84 lib/_internal/libraries.dart:84: platforms: VM_PLATFORM), On 2012/08/23 18:03:11, keertip wrote: > Add ...
8 years, 4 months ago (2012-08-23 18:12:02 UTC) #3
danrubel
8 years, 4 months ago (2012-08-24 13:40:50 UTC) #4
Lasse Reichstein Nielsen
8 years, 3 months ago (2012-09-12 10:19:54 UTC) #5
https://chromiumcodereview.appspot.com/10876045/diff/5001/lib/_internal/libra...
File lib/_internal/libraries.dart (right):

https://chromiumcodereview.appspot.com/10876045/diff/5001/lib/_internal/libra...
lib/_internal/libraries.dart:35: platforms: 0),
drive-by-after-the-fact-comment: Consider making NO_PLATFORM=0 a constant. It
might be a little much for one use, but magic constants suck :)

https://chromiumcodereview.appspot.com/10876045/diff/5001/lib/_internal/libra...
lib/_internal/libraries.dart:170: bool isDart2JsLibrary() => (platforms &
DART2JS_PLATFORM) != 0;
You could even use the NO_PLATFORM for the zeros here.

Powered by Google App Engine
This is Rietveld 408576698