Issue 10876011: dart2dart Make sure we never create placeholder for Dynamic type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10876011: dart2dart Make sure we never create placeholder for Dynamic type. (Closed)

Created:
8 years, 4 months ago by Roman

Modified:
8 years, 4 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

dart2dart Make sure we never create placeholder for Dynamic type. Committed: https://code.google.com/p/dart/source/detail?r=11141

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	lib/compiler/implementation/dart_backend/placeholder_collector.dart	View		2 chunks	+6 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Roman

It's not easy to provide a test here. '==' for types does not always provide ...

8 years, 4 months ago (2012-08-22 12:40:46 UTC) #3

That's somewhat pity, but okay.

Still LGTM