Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 10876008: Remove most superfluous getter arguments from dart2js. (Closed)

Created:
8 years, 4 months ago by ahe
Modified:
8 years, 4 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, dgrove, hausner
Visibility:
Public.

Description

Remove most superfluous getter arguments from dart2js. Committed: https://code.google.com/p/dart/source/detail?r=11123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -318 lines) Patch
M dart/lib/compiler/implementation/apiimpl.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/code_buffer.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/compile_time_constants.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M dart/lib/compiler/implementation/compiler.dart View 5 chunks +7 lines, -7 lines 0 comments Download
M dart/lib/compiler/implementation/dart_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/dart_backend/dart_backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/elements/elements.dart View 18 chunks +26 lines, -26 lines 0 comments Download
M dart/lib/compiler/implementation/enqueue.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M dart/lib/compiler/implementation/js/nodes.dart View 17 chunks +28 lines, -28 lines 0 comments Download
M dart/lib/compiler/implementation/js/printer.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/js_backend/backend.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/lib/compiler/implementation/js_backend/emitter.dart View 6 chunks +13 lines, -13 lines 0 comments Download
M dart/lib/compiler/implementation/js_backend/native_emitter.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M dart/lib/compiler/implementation/lib/coreimpl_patch.dart View 1 chunk +10 lines, -10 lines 0 comments Download
M dart/lib/compiler/implementation/lib/io.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M dart/lib/compiler/implementation/lib/isolate_patch.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M dart/lib/compiler/implementation/namer.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/patch_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/resolver.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M dart/lib/compiler/implementation/scanner/array_based_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/scanner/byte_strings.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/scanner/keyword.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M dart/lib/compiler/implementation/scanner/parser_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/scanner/scanner_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/scanner/string_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/scanner/token.dart View 5 chunks +7 lines, -7 lines 0 comments Download
M dart/lib/compiler/implementation/script.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/lib/compiler/implementation/source_file.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/ssa/bailout.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/ssa/builder.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M dart/lib/compiler/implementation/ssa/codegen.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M dart/lib/compiler/implementation/ssa/js_names.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/ssa/nodes.dart View 59 chunks +97 lines, -97 lines 0 comments Download
M dart/lib/compiler/implementation/ssa/optimize.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M dart/lib/compiler/implementation/ssa/types_propagation.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/ssa/value_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/tools/mini_parser.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/lib/compiler/implementation/tree/dartstring.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M dart/lib/compiler/implementation/tree/nodes.dart View 20 chunks +34 lines, -34 lines 0 comments Download
M dart/lib/compiler/implementation/typechecker.dart View 7 chunks +8 lines, -8 lines 0 comments Download
M dart/lib/compiler/implementation/universe.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M dart/lib/compiler/implementation/util/link_implementation.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ahe
dart2js still cannot handle abstract getters without parentheses. So there are some warnings remaining: lib/compiler/implementation/compiler.dart:59:40: ...
8 years, 4 months ago (2012-08-22 06:19:23 UTC) #1
kasperl
8 years, 4 months ago (2012-08-22 06:28:38 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698