Fixing up some APIs to allow Web DB to work from dart and adding tests.

Fixing up some APIs to allow Web DB to work from dart and adding tests.

Basically the SQLTransaction.executeSQL was being ommitted because the compiler didn't recognize the ObjectArray type. Adding this in makes this work in dart2js sscenarios (where the browser supports it).

I've opened bug #4645 that the APIs need to be implemented in Dartium.


BUG=1888
Committed: https://code.google.com/p/dart/source/detail?r=11272

[sra1, 2012-08-23 17:52:39]

lgtm

https://chromiumcodereview.appspot.com/10876002/diff/21/tests/html/websql_tes...
File tests/html/websql_test.dart (right):

https://chromiumcodereview.appspot.com/10876002/diff/21/tests/html/websql_tes...
tests/html/websql_test.dart:30: });
Indentation of these things is tricky.  The } should not be at the indent of the
enclosing call, so the body of the anonymous functions should be +4 (i.e, two
indents)

Something like this might be better

  transaction.executeSql(sql, [],
    (SQLTransaction tx, SQLResultSet rs) {
      completer.complete(transaction);
    },
    (SQLTransaction tx, SQLError error) {
      fail(error.message);
    });

https://chromiumcodereview.appspot.com/10876002/diff/21/tests/html/websql_tes...
tests/html/websql_test.dart:92: // Attempt to clear out any tables which may be
lurking from previous runs.
Line length

[blois, 2012-08-23 18:15:31]

https://chromiumcodereview.appspot.com/10876002/diff/21/tests/html/websql_tes...
File tests/html/websql_test.dart (right):

https://chromiumcodereview.appspot.com/10876002/diff/21/tests/html/websql_tes...
tests/html/websql_test.dart:30: });
On 2012/08/23 17:52:39, sra1 wrote:
> Indentation of these things is tricky.  The } should not be at the indent of
the
> enclosing call, so the body of the anonymous functions should be +4 (i.e, two
> indents)
> 
> Something like this might be better
> 
>   transaction.executeSql(sql, [],
>     (SQLTransaction tx, SQLResultSet rs) {
>       completer.complete(transaction);
>     },
>     (SQLTransaction tx, SQLError error) {
>       fail(error.message);
>     });

Done.

https://chromiumcodereview.appspot.com/10876002/diff/21/tests/html/websql_tes...
tests/html/websql_test.dart:92: // Attempt to clear out any tables which may be
lurking from previous runs.
On 2012/08/23 17:52:39, sra1 wrote:
> Line length

Done.