Issue 10875058: Require ResultCid specification in every computation, that way we can differentiate between computa…

Issue 10875058: Require ResultCid specification in every computation, that way we can differentiate between computa… (Closed)

Created:
8 years, 4 months ago by srdjan

Modified:
8 years, 4 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Require ResultCid specification in every computation, that way we can differentiate between computation that do not produce results (kIllegalCid as result-cid). Committed: https://code.google.com/p/dart/source/detail?r=11346

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -3 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View		37 chunks	+39 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10875058/diff/3002/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (left): https://chromiumcodereview.appspot.com/10875058/diff/3002/runtime/vm/flow_graph_optimizer.cc#oldcode972 runtime/vm/flow_graph_optimizer.cc:972: Accidental remove? https://chromiumcodereview.appspot.com/10875058/diff/3002/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://chromiumcodereview.appspot.com/10875058/diff/3002/runtime/vm/flow_graph_optimizer.cc#newcode926 runtime/vm/flow_graph_optimizer.cc:926: ...

8 years, 4 months ago (2012-08-24 21:30:46 UTC) #2

srdjan

8 years, 4 months ago (2012-08-24 21:39:20 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10875058/diff/3002/runtime/vm/flow_gra...
File runtime/vm/flow_graph_optimizer.cc (left):

https://chromiumcodereview.appspot.com/10875058/diff/3002/runtime/vm/flow_gra...
runtime/vm/flow_graph_optimizer.cc:972: 
On 2012/08/24 21:30:46, regis wrote:
> Accidental remove?

Yes, reinstated the line.

https://chromiumcodereview.appspot.com/10875058/diff/3002/runtime/vm/flow_gra...
File runtime/vm/flow_graph_optimizer.cc (right):

https://chromiumcodereview.appspot.com/10875058/diff/3002/runtime/vm/flow_gra...
runtime/vm/flow_graph_optimizer.cc:926: if (cid != kIllegalCid) {
On 2012/08/24 21:30:46, regis wrote:
> The equivalent of this test for propagated types is done inside
> bind->SetPropagatedType(computation_type). You could keep the symmetry and
move
> this new test inside bind->SetPropagatedCid(cid).

Done.

Expand Messages | Collapse Messages