Issue 10875040: Support customizing API (and hence mock) compiler to minify the output.

Issue 10875040: Support customizing API (and hence mock) compiler to minify the output. (Closed)

Created:
8 years, 4 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support customizing API (and hence mock) compiler to minify the output. R=smok@google.com Committed: https://code.google.com/p/dart/source/detail?r=11295

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -11 lines)			Patch
M	lib/compiler/implementation/apiimpl.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/compiler.dart	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/dart_backend/backend.dart	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/dart_backend/renamer.dart	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/unparser_test.dart	View		4 chunks	+23 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Roman

lgtm https://chromiumcodereview.appspot.com/10875040/diff/1/lib/compiler/implementation/dart_backend/backend.dart File lib/compiler/implementation/dart_backend/backend.dart (right): https://chromiumcodereview.appspot.com/10875040/diff/1/lib/compiler/implementation/dart_backend/backend.dart#newcode105 lib/compiler/implementation/dart_backend/backend.dart:105: Generator topLevelGenerator = It is weird that generators ...

8 years, 4 months ago (2012-08-24 07:21:04 UTC) #2

Roman

https://chromiumcodereview.appspot.com/10875040/diff/1/lib/compiler/implementation/dart_backend/backend.dart File lib/compiler/implementation/dart_backend/backend.dart (right): https://chromiumcodereview.appspot.com/10875040/diff/1/lib/compiler/implementation/dart_backend/backend.dart#newcode105 lib/compiler/implementation/dart_backend/backend.dart:105: Generator topLevelGenerator = On 2012/08/24 07:21:04, Roman wrote: > ...

8 years, 4 months ago (2012-08-24 07:27:01 UTC) #3

Anton Muhin

8 years, 4 months ago (2012-08-24 08:42:53 UTC) #4

https://chromiumcodereview.appspot.com/10875040/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10875040/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:105: Generator
topLevelGenerator =
On 2012/08/24 07:27:01, Roman wrote:
> On 2012/08/24 07:21:04, Roman wrote:
> > It is weird that generators are defined in renamer.dart, but you use them
from
> > here. It should look better if either:
> > 1) pass minify to renamePlaceholders()
> > 2) or move MinifyingGenerator and ConservativeGenerator to this file.
> 
> I just thought it would be better to pass the flag, because with my CL there
> will be minifying generator for locals too, and it should have different
> alphabet, so it would be:
> 1) pass minify to renamePlacheolders()
> 2) pass both top-level generator and local generator to renamer

Done.

https://chromiumcodereview.appspot.com/10875040/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:106: minify ? new
MinifyingGenerator('ABCD').generate : conservativeGenerator;
Now obsolete

On 2012/08/24 07:21:04, Roman wrote:
> 80 chars

Expand Messages | Collapse Messages