Issue 10874071: Eliminate interface bool

Issue 10874071: Eliminate interface bool (Closed)

Created:
8 years, 4 months ago by hausner

Modified:
8 years, 3 months ago

Reviewers:
turnidge, gbracha, Ivan Posva

CC:
reviews_dartlang.org, gbracha, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Eliminate interface bool Replace with concrete class bool instead, and getting rid of class Bool in core_impl library. Committed: https://code.google.com/p/dart/source/detail?r=11418

Patch Set 5 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -57 lines)			Patch
M	corelib/src/bool.dart	View	1 2 3 4	1 chunk	+5 lines, -1 line	0 comments	Download
D	runtime/lib/bool.dart	View	1 2 3 4	1 chunk	+0 lines, -10 lines	0 comments	Download
M	runtime/lib/lib_impl_sources.gypi	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart_api_message.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2 3 4	5 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4	3 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4	6 chunks	+9 lines, -12 lines	0 comments	Download
M	runtime/vm/object_store.h	View	1 2 3 4	2 chunks	+3 lines, -5 lines	0 comments	Download
M	runtime/vm/object_store.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object_test.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	1 2 3 4	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/snapshot_ids.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/symbols.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

turnidge

DBC http://codereview.chromium.org/10874071/diff/8003/runtime/vm/object.cc File runtime/vm/object.cc (right): http://codereview.chromium.org/10874071/diff/8003/runtime/vm/object.cc#newcode1168 runtime/vm/object.cc:1168: return Symbols::New("bool"); Do we still need this special ...

8 years, 4 months ago (2012-08-24 23:58:31 UTC) #3

hausner

Good catch http://codereview.chromium.org/10874071/diff/8003/runtime/vm/object.cc File runtime/vm/object.cc (right): http://codereview.chromium.org/10874071/diff/8003/runtime/vm/object.cc#newcode1168 runtime/vm/object.cc:1168: return Symbols::New("bool"); On 2012/08/24 23:58:31, turnidge wrote: ...

8 years, 4 months ago (2012-08-25 00:32:40 UTC) #4

Ivan Posva

LGTM -ip https://chromiumcodereview.appspot.com/10874071/diff/6008/runtime/vm/object.cc File runtime/vm/object.cc (right): https://chromiumcodereview.appspot.com/10874071/diff/6008/runtime/vm/object.cc#newcode791 runtime/vm/object.cc:791: cls = object_store->bool_class(); Can you move this ...

8 years, 3 months ago (2012-08-27 20:47:51 UTC) #5

hausner

8 years, 3 months ago (2012-08-27 21:08:19 UTC) #6

Thanks

https://chromiumcodereview.appspot.com/10874071/diff/6008/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/10874071/diff/6008/runtime/vm/object.c...
runtime/vm/object.cc:791: cls = object_store->bool_class();
On 2012/08/27 20:47:51, Ivan Posva wrote:
> Can you move this down together with the smi_class() and friends? It looks
> slightly out of place here.

Done.

Expand Messages | Collapse Messages