Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 10874051: Support self-referential package: imports with Pub. (Closed)

Created:
8 years, 4 months ago by nweiz
Modified:
8 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support self-referential package: imports with Pub. Committed: https://code.google.com/p/dart/source/detail?r=11334

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -36 lines) Patch
M utils/pub/entrypoint.dart View 1 6 chunks +42 lines, -8 lines 0 comments Download
M utils/pub/git_source.dart View 4 chunks +6 lines, -7 lines 0 comments Download
M utils/pub/package.dart View 2 chunks +9 lines, -7 lines 0 comments Download
M utils/pub/pubspec.dart View 4 chunks +16 lines, -3 lines 0 comments Download
M utils/pub/sdk_source.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/pub_test.dart View 1 3 chunks +62 lines, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 2 chunks +10 lines, -7 lines 0 comments Download
M utils/tests/pub/version_solver_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
8 years, 4 months ago (2012-08-24 00:35:48 UTC) #1
Bob Nystrom
Couple of nits, but LGTM. When this goes in, please send a "BREAKING CHANGE" email ...
8 years, 4 months ago (2012-08-24 00:58:49 UTC) #2
nweiz
8 years, 4 months ago (2012-08-24 01:12:12 UTC) #3
https://chromiumcodereview.appspot.com/10874051/diff/1/utils/pub/entrypoint.dart
File utils/pub/entrypoint.dart (right):

https://chromiumcodereview.appspot.com/10874051/diff/1/utils/pub/entrypoint.d...
utils/pub/entrypoint.dart:215: throw '"pubspec.yaml" not found.';
On 2012/08/24 00:58:49, Bob Nystrom wrote:
> We should do friendly error messages here. Something like "Could not find a
> 'pubspec.yaml' file in the directory <path>.".
> 
> Also add a TODO to mention "pub init" in the error when that's implemented.

Done.

https://chromiumcodereview.appspot.com/10874051/diff/1/utils/pub/entrypoint.d...
utils/pub/entrypoint.dart:221: throw '"pubspec.yaml" must contain a "name"
key.';
On 2012/08/24 00:58:49, Bob Nystrom wrote:
> Make this a friendly complete sentence, please.

This one is a complete sentence. I'd be happy to rewrite it, but I'm not sure
how best to do so.

Powered by Google App Engine
This is Rietveld 408576698