Use ephemeral ports for serving stuff during the pub tests.

Use ephemeral ports for serving stuff during the pub tests.

BUG=4531
Committed: https://code.google.com/p/dart/source/detail?r=11274

[Bob Nystrom, 2012-08-23 21:49:13]

https://chromiumcodereview.appspot.com/10874039/diff/1/utils/tests/pub/test_p...
File utils/tests/pub/test_pub.dart (right):

https://chromiumcodereview.appspot.com/10874039/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:67: Completer<int> get _portCompleter() {
New getter syntax. :)

https://chromiumcodereview.appspot.com/10874039/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:153: * those packagesk. This represents the
packages currently being served by
"packagesk" -> "packages".

https://chromiumcodereview.appspot.com/10874039/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:180: return
Futures.wait(pubspecs.map(_awaitObject))
Can you just do _awaitObject(pubspects)?

https://chromiumcodereview.appspot.com/10874039/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:185: var versions =
_servedPackages.putIfAbsent(name, () => <String, String>{});
Long line.

https://chromiumcodereview.appspot.com/10874039/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:193: JSON.stringify({'versions':
_servedPackages[name].getKeys()})),
+2

https://chromiumcodereview.appspot.com/10874039/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:195: dir('versions',
flatten(_servedPackages[name].getKeys().map((version) {
Lone line.

[nweiz, 2012-08-23 22:25:49]

https://chromiumcodereview.appspot.com/10874039/diff/1/utils/tests/pub/test_p...
File utils/tests/pub/test_pub.dart (right):

https://chromiumcodereview.appspot.com/10874039/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:67: Completer<int> get _portCompleter() {
On 2012/08/23 21:49:13, Bob Nystrom wrote:
> New getter syntax. :)

Done.

https://chromiumcodereview.appspot.com/10874039/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:153: * those packagesk. This represents the
packages currently being served by
On 2012/08/23 21:49:13, Bob Nystrom wrote:
> "packagesk" -> "packages".

Done.

https://chromiumcodereview.appspot.com/10874039/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:180: return
Futures.wait(pubspecs.map(_awaitObject))
On 2012/08/23 21:49:13, Bob Nystrom wrote:
> Can you just do _awaitObject(pubspects)?

Done.

https://chromiumcodereview.appspot.com/10874039/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:185: var versions =
_servedPackages.putIfAbsent(name, () => <String, String>{});
On 2012/08/23 21:49:13, Bob Nystrom wrote:
> Long line.

Done.

https://chromiumcodereview.appspot.com/10874039/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:193: JSON.stringify({'versions':
_servedPackages[name].getKeys()})),
On 2012/08/23 21:49:13, Bob Nystrom wrote:
> +2

Done.

https://chromiumcodereview.appspot.com/10874039/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:195: dir('versions',
flatten(_servedPackages[name].getKeys().map((version) {
On 2012/08/23 21:49:13, Bob Nystrom wrote:
> Lone line.

Done.

[Bob Nystrom, 2012-08-23 22:27:33]

LGTM!