Issue 10874038: Make StringBase._substringUnchecked a native function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10874038: Make StringBase._substringUnchecked a native function. (Closed)

Created:
8 years, 4 months ago by turnidge

Modified:
8 years, 4 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make StringBase._substringUnchecked a native function. This avoids making a throw-away list on every substring operation. Fixed the underscore on the function name while I was at it. Committed: https://code.google.com/p/dart/source/detail?r=11262

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -12 lines)			Patch
M	runtime/lib/regexp_patch.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/string.cc	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	runtime/lib/string.dart	View	2 chunks	+4 lines, -10 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

8 years, 4 months ago (2012-08-23 21:34:06 UTC) #2

LGTM -ip

https://chromiumcodereview.appspot.com/10874038/diff/1/runtime/lib/string.cc
File runtime/lib/string.cc (right):

https://chromiumcodereview.appspot.com/10874038/diff/1/runtime/lib/string.cc#...
runtime/lib/string.cc:69: 
One too many lines.

Expand Messages | Collapse Messages