Get library data from lib/_internal/libraries.dart.

Get library data from lib/_internal/libraries.dart.

Committed: https://code.google.com/p/dart/source/detail?r=11435

[Lasse Reichstein Nielsen, 2012-08-23 12:49:15]

Won't commit until I'm sure dartdoc runs.

[ahe, 2012-08-23 13:00:27]

I would like some context. I don't understand why
lib/compiler/implementation/library_map.dart is not deleted.

[Johnni Winther, 2012-08-23 13:04:12]

On 2012/08/23 13:00:27, ahe wrote:
> I would like some context. I don't understand why
> lib/compiler/implementation/library_map.dart is not deleted.

It is still used by dartdoc/apidoc.

[ahe, 2012-08-23 13:11:46]

On 2012/08/23 13:04:12, Johnni Winther wrote:
> On 2012/08/23 13:00:27, ahe wrote:
> > I would like some context. I don't understand why
> > lib/compiler/implementation/library_map.dart is not deleted.
> 
> It is still used by dartdoc/apidoc.

Why is dartdoc/apidoc not updated to use lib/_internal/libraries.dart?

[Lasse Reichstein Nielsen, 2012-08-23 13:12:14]

On 2012/08/23 13:00:27, ahe wrote:
> I would like some context. I don't understand why
> lib/compiler/implementation/library_map.dart is not deleted.

Primarily because this is the minimum change needed to start using the data in
libraries.dart.
After that, we can start changing use-places to use the data directly (if
possible).

[Lasse Reichstein Nielsen, 2012-08-24 11:47:06]

I made apidoc.dart use libraries.dart directly, and changed libraries.dart to
contain the information needed.

This changes the fields on LibraryInfo in libraries.dart. Dan, can the editor
live with these changes, or does it need to change too?

I still want to remove the library_map.dart file, but I'd prefer to do that in a
separate CL, now that it only affects dart2js.

[Johnni Winther, 2012-08-24 13:15:55]

LGTM with comment

https://chromiumcodereview.appspot.com/10874030/diff/5001/lib/_internal/libra...
File lib/_internal/libraries.dart (right):

https://chromiumcodereview.appspot.com/10874030/diff/5001/lib/_internal/libra...
lib/_internal/libraries.dart:41: undocumented: false),
I guess this should be true.

[ahe, 2012-08-24 13:36:18]

LGTM under the assumption that you plan to delete library_map.dart in the next
CL.

[danrubel, 2012-08-24 13:40:13]

On 2012/08/24 13:36:18, ahe wrote:
> LGTM under the assumption that you plan to delete library_map.dart in the next
> CL.

I'm working on something similar...
http://codereview.chromium.org/10876045/