Issue 10873037: Support methods, getters, and setters on JS proxies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10873037: Support methods, getters, and setters on JS proxies. (Closed)

Created:
8 years, 4 months ago by vsm

Modified:
8 years, 4 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support methods, getters, and setters on JS proxies. Committed: https://code.google.com/p/dart/source/detail?r=11345

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments, cleanuo #

Patch Set 3 : Fixes for DartVM #

Patch Set 4 : Fix status #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+294 lines, -170 lines)			Patch
M	client/dart.js	View	1	4 chunks	+113 lines, -71 lines	0 comments	Download
M	lib/html/dart2js/html_dart2js.dart	View		9 chunks	+44 lines, -33 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		9 chunks	+44 lines, -33 lines	0 comments	Download
M	lib/html/src/Isolates.dart	View	1 2	9 chunks	+40 lines, -33 lines	0 comments	Download
M	tests/html/html.status	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
A	tests/html/js_interop_obj_invoke_test.dart	View		1 chunk	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

8 years, 4 months ago (2012-08-23 21:04:35 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10873037/diff/1/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10873037/diff/1/client/dart.js#newcode86
client/dart.js:86: return [ 'objref', message._id, doSerialize(message._port) ];
An overall comment for doSerialize about the format you're returning
[messageType, id, port] would be nice

https://chromiumcodereview.appspot.com/10873037/diff/1/lib/html/src/Isolates....
File lib/html/src/Isolates.dart (right):

https://chromiumcodereview.appspot.com/10873037/diff/1/lib/html/src/Isolates....
lib/html/src/Isolates.dart:201: throw 'Illegal proxy: $port';
When would this case happen? Can we provide a more useful error message?

Expand Messages | Collapse Messages