Issue 10873036: Add convenience static members of Type: Smi and Mint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10873036: Add convenience static members of Type: Smi and Mint. (Closed)

Created:
8 years, 4 months ago by regis

Modified:
8 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add convenience static members of Type: Smi and Mint. Use them during type propagation. Various cleanups. Committed: https://code.google.com/p/dart/source/detail?r=11258

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -19 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	4 chunks	+12 lines, -8 lines	0 comments	Download
M	runtime/vm/object.h	View	1	2 chunks	+10 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	2 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10873036/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://chromiumcodereview.appspot.com/10873036/diff/1/runtime/vm/intermediate_language.cc#newcode929 runtime/vm/intermediate_language.cc:929: return AbstractType::null(); Please add comment why is that ...

8 years, 4 months ago (2012-08-23 19:12:59 UTC) #2

regis

8 years, 4 months ago (2012-08-23 21:03:34 UTC) #3

Thanks.

https://chromiumcodereview.appspot.com/10873036/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.cc (right):

https://chromiumcodereview.appspot.com/10873036/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.cc:929: return AbstractType::null();
On 2012/08/23 19:12:59, srdjan wrote:
> Please add comment why is that necessary, why we cannot just return
type().raw()

In production mode, the type of the local is not guaranteed and we return
Dynamic, but it would be wrong to return Dynamic when the type should never be
used (null).
Added comment.

Expand Messages | Collapse Messages

Issue 10873036: Add convenience static members of Type: Smi and Mint. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages