Inlining of static functions: applying Florian's CL.

Inlining of static functions: applying Florian's CL.
Committed: https://code.google.com/p/dart/source/detail?r=11226

[ngeoffray, 2012-08-23 08:51:16]

Patch taken as-is with some cosmetic changes, mostly comments.

[kasperl, 2012-08-23 09:18:51]

LGTM.

https://chromiumcodereview.appspot.com/10873025/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10873025/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/builder.dart:963: // TODO(ngeoffray): Inlining
currently does not work in the presence of
I wonder if this restriction could be lifted. Maybe in another CL.

https://chromiumcodereview.appspot.com/10873025/diff/1/tests/compiler/dart2js...
File tests/compiler/dart2js/call_site_type_inferer_static_test.dart (right):

https://chromiumcodereview.appspot.com/10873025/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/call_site_type_inferer_static_test.dart:70: g(p) {if (p==
null) return null; return p(1); }
Space before if.

https://chromiumcodereview.appspot.com/10873025/diff/1/tests/compiler/dart2js...
File tests/compiler/dart2js/generate_at_use_site_test.dart (right):

https://chromiumcodereview.appspot.com/10873025/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/generate_at_use_site_test.dart:19: add(x, y) {
How hard would it be to use an annotation for this instead? 

   @noinline
   add(x, y)

Maybe it's too complicated...

https://chromiumcodereview.appspot.com/10873025/diff/1/tests/language/languag...
File tests/language/language_dart2js.status (right):

https://chromiumcodereview.appspot.com/10873025/diff/1/tests/language/languag...
tests/language/language_dart2js.status:52: compile_time_constant_test/02: Fail,
Ok # By inlining the use-function we don't compile the static variable.
Ok -> OK

[ngeoffray, 2012-08-23 12:19:02]

Thanks Kasper

https://chromiumcodereview.appspot.com/10873025/diff/1/tests/compiler/dart2js...
File tests/compiler/dart2js/call_site_type_inferer_static_test.dart (right):

https://chromiumcodereview.appspot.com/10873025/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/call_site_type_inferer_static_test.dart:70: g(p) {if (p==
null) return null; return p(1); }
On 2012/08/23 09:18:51, kasperl wrote:
> Space before if.

Done.

https://chromiumcodereview.appspot.com/10873025/diff/1/tests/compiler/dart2js...
File tests/compiler/dart2js/generate_at_use_site_test.dart (right):

https://chromiumcodereview.appspot.com/10873025/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/generate_at_use_site_test.dart:19: add(x, y) {
On 2012/08/23 09:18:51, kasperl wrote:
> How hard would it be to use an annotation for this instead? 
> 
>    @noinline
>    add(x, y)
> 
> Maybe it's too complicated...

I'll make sure we have that annotation once the annotation api is in.

https://chromiumcodereview.appspot.com/10873025/diff/1/tests/language/languag...
File tests/language/language_dart2js.status (right):

https://chromiumcodereview.appspot.com/10873025/diff/1/tests/language/languag...
tests/language/language_dart2js.status:52: compile_time_constant_test/02: Fail,
Ok # By inlining the use-function we don't compile the static variable.
On 2012/08/23 09:18:51, kasperl wrote:
> Ok -> OK

Done.

[ahe, 2012-12-05 10:25:50]

FYI

https://chromiumcodereview.appspot.com/10873025/diff/9001/tests/co19/co19-dar...
File tests/co19/co19-dart2js.status (right):

https://chromiumcodereview.appspot.com/10873025/diff/9001/tests/co19/co19-dar...
tests/co19/co19-dart2js.status:423: LibTest/core/int/operator_NOT_A01_t01: Pass
It would be great if you could avoid marking tests as "pass".  In practice, this
often leads to tests being incorrectly marked as flaky.