Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 10872043: - Remove redundant assertion. (Closed)

Created:
8 years, 4 months ago by Ivan Posva
Modified:
8 years, 4 months ago
Reviewers:
cshapiro, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Remove redundant assertion. - Add flag --verify-handles to enable checking when assigning to handles. Committed: https://code.google.com/p/dart/source/detail?r=11250

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M runtime/vm/gc_marker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/handles.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/handles.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
8 years, 4 months ago (2012-08-23 18:32:57 UTC) #1
cshapiro
lgtm
8 years, 4 months ago (2012-08-23 18:47:41 UTC) #2
siva
8 years, 4 months ago (2012-08-23 18:49:55 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698