Issue 10872029: Quick fix for SDK after Expando addition in the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10872029: Quick fix for SDK after Expando addition in the VM. (Closed)

Created:
8 years, 4 months ago by Mads Ager (google)

Modified:
8 years, 4 months ago

Reviewers:
Anders Johnsen, cshapiro

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Quick fix for SDK after Expando addition in the VM. Two files named expando.dart leads to one overwriting the other in the SDK. Maybe we should use patching for Expando? In any case, we are working towards not having the implementation file in the SDK at which point we can revert this change. Minor style cleanup. R=ajohnsen@google.com,cshapiro@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11210

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -115 lines)			Patch
D	runtime/lib/expando.dart	View	1 chunk	+0 lines, -98 lines	0 comments	Download
A +	runtime/lib/expando_impl.dart	View	6 chunks	+16 lines, -16 lines	0 comments	Download
M	runtime/lib/lib_sources.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

lgtm - thanks!

Expand Messages | Collapse Messages