Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 10871070: Provide a constructor for (DOM)FormData, and rename to the more standard name, (Closed)

Created:
8 years, 4 months ago by Emily Fortuna
Modified:
8 years, 3 months ago
Reviewers:
vsm, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Provide a constructor for (DOM)FormData, and rename to the more standard name, FormData. Also add a constructor for FormElement. Committed: https://code.google.com/p/dart/source/detail?r=11459

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -91 lines) Patch
M lib/dom/dart2js/dom_dart2js.dart View 1 5 chunks +25 lines, -18 lines 0 comments Download
M lib/dom/dom.dart View 1 3 chunks +19 lines, -13 lines 0 comments Download
M lib/dom/idl/dart/dart.idl View 1 1 chunk +9 lines, -0 lines 0 comments Download
M lib/dom/scripts/dartdomgenerator.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M lib/dom/scripts/systemhtml.py View 1 1 chunk +1 line, -1 line 0 comments Download
A lib/dom/templates/html/dart2js/factoryprovider_FormData.darttemplate View 1 1 chunk +10 lines, -0 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 6 chunks +37 lines, -18 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 5 chunks +41 lines, -24 lines 0 comments Download
M lib/html/doc/html.dartdoc View 1 2 2 chunks +1 line, -1 line 0 comments Download
D lib/html/doc/interface/DOMFormData.dartdoc View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
A + lib/html/doc/interface/FormData.dartdoc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A tests/html/form_data_test.dart View 1 1 chunk +36 lines, -0 lines 0 comments Download
A tests/html/form_element_test.dart View 1 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
Working on adding a test for this, but it's pretty complicated -- (our test framework ...
8 years, 4 months ago (2012-08-25 00:34:10 UTC) #1
sra1
LGTM with a lame test. We have some pretty lame tests - look at audioelement_test. ...
8 years, 4 months ago (2012-08-25 01:37:21 UTC) #2
Emily Fortuna
PTAL -- Vijay. I ended up adding the FormElement constructor fix to this CL because ...
8 years, 3 months ago (2012-08-28 00:04:24 UTC) #3
vsm
8 years, 3 months ago (2012-08-28 14:57:32 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698