Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 10871063: Infer and merge variable types with multiple assignments in conditional statements (Closed)

Created:
8 years, 4 months ago by scheglov
Modified:
8 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Infer and merge variable types with multiple assignments in conditional statements This covers also case of declaring variable without value and assignment later. This is just special case of multiple assignments in the same basic block. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11324

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -29 lines) Patch
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 11 chunks +127 lines, -23 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 2 chunks +166 lines, -6 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 4 months ago (2012-08-24 16:26:24 UTC) #1
Brian Wilkerson
8 years, 4 months ago (2012-08-24 16:45:51 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698