Issue 10870111: Remove weak_property from lib_sources.gypi, since it's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10870111: Remove weak_property from lib_sources.gypi, since it's (Closed)

Created:
8 years, 3 months ago by dgrove

Modified:
8 years, 3 months ago

Reviewers:
Mads Ager (google), Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Remove weak_property from lib_sources.gypi, since it's already in lib_impl_sources.gypi Committed: https://code.google.com/p/dart/source/detail?r=11419

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	runtime/lib/lib_sources.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Mads Ager (google)

LGTM. Sorry about that. I moved them but my changes have been stacking up because ...

8 years, 3 months ago (2012-08-28 06:00:35 UTC) #4

ahe

8 years, 3 months ago (2012-08-28 07:01:17 UTC) #5

Dan,

For my education: how did you notice this? Did you get linker errors?

Cheers,
Peter