Issue 10870089: Issue 4681. Resolve @metadata for all possible targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10870089: Issue 4681. Resolve @metadata for all possible targets (Closed)

Created:
8 years, 4 months ago by scheglov

Modified:
8 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 4681. Resolve @metadata for all possible targets http://code.google.com/p/dart/issues/detail?id=4681 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11361

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -8 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/ASTVisitor.java	View	3 chunks	+7 lines, -3 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	9 chunks	+27 lines, -1 line	2 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	5 chunks	+26 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM, but I think metadata ought to be treated like any other child node. https://chromiumcodereview.appspot.com/10870089/diff/1/compiler/java/com/google/dart/compiler/resolver/Resolver.java ...

8 years, 4 months ago (2012-08-25 02:12:55 UTC) #2

scheglov

8 years, 4 months ago (2012-08-25 03:41:32 UTC) #3

https://chromiumcodereview.appspot.com/10870089/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right):

https://chromiumcodereview.appspot.com/10870089/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:240:
alias.getMetadata().accept(this);
On 2012/08/25 02:12:55, Brian Wilkerson wrote:
> Shouldn't this be added to the visitChildren method on nodes with metadata?

Unfortunately Resolver has its own visiting implementation, specific for each
type of node. As you can see, we don't call super() here, we manually visit each
child. So, we have to do the same with metadata.

Expand Messages | Collapse Messages