Use patching for Expando so the implementation-specific files are not needed in the SDK.

Use patching for Expando so the implementation-specific files are not needed in the SDK.

Make extra methods private in VM version.

R=ajohnsen@google.com,cshapiro@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=11369

[Mads Ager (google), 2012-08-24 11:15:23]

Carl, could you have a look at the comment in object.cc?

https://chromiumcodereview.appspot.com/10870064/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/10870064/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:636: pending_classes.Add(cls, Heap::kOld);
Carl, this reflects the move of the class from core to coreimpl. I added the
addition to pending_classes just to keep it consistent with the above. Is that
the right thing to do or should I leave out the addition to pending_classes?

[Anders Johnsen, 2012-08-24 12:07:27]

LGTM, very nice.

[cshapiro, 2012-08-25 03:18:28]

lgtm

https://chromiumcodereview.appspot.com/10870064/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/10870064/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:636: pending_classes.Add(cls, Heap::kOld);
I believe you have done the right thing.  

When something goes wrong in this function, you tend to find out pretty quickly.
 If you have run all of the unit tests and they have passed, I think you can be
confident that this change is okay.

[Ivan Posva, 2012-08-27 21:16:21]

https://chromiumcodereview.appspot.com/10870064/diff/3002/corelib/src/expando...
File corelib/src/expando.dart (right):

https://chromiumcodereview.appspot.com/10870064/diff/3002/corelib/src/expando...
corelib/src/expando.dart:8: interface Expando<T> default
ExpandoImplementation<T> {
Why this extra indirection?

class Expando<T> {

  external ...

}

[Mads Ager (google), 2012-08-28 06:01:40]

On 2012/08/27 21:16:21, Ivan Posva wrote:
>
https://chromiumcodereview.appspot.com/10870064/diff/3002/corelib/src/expando...
> File corelib/src/expando.dart (right):
> 
>
https://chromiumcodereview.appspot.com/10870064/diff/3002/corelib/src/expando...
> corelib/src/expando.dart:8: interface Expando<T> default
> ExpandoImplementation<T> {
> Why this extra indirection?
> 
> class Expando<T> {
> 
>   external ...
> 
> }

To avoid patching corelib. We can do it the other way as well if you prefer. At
this point there is a lot of indirection through coreimpl and we can clean that
up.