Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 10870058: Use intersection of types as type of conditional (Closed)

Created:
8 years, 4 months ago by scheglov
Modified:
8 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use intersection of types as type of conditional This is actually preparation for type propagation in case of multiple assignments to variable. For example when there are assignments in IfStatement, different types in "then" and "else" branches. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -13 lines) Patch
A compiler/java/com/google/dart/compiler/resolver/ClassElementUnion.java View 1 chunk +196 lines, -0 lines 0 comments Download
A compiler/java/com/google/dart/compiler/type/InterfaceTypeUnion.java View 1 chunk +98 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/type/Types.java View 4 chunks +65 lines, -12 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 4 months ago (2012-08-24 03:21:26 UTC) #1
Brian Wilkerson
8 years, 4 months ago (2012-08-24 14:44:25 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698