Issue 10870053: Fix Growable array set length intrinsics to check if the incoming value is a Smi, otherwise call na…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10870053: Fix Growable array set length intrinsics to check if the incoming value is a Smi, otherwise call na… (Closed)

Created:
8 years, 4 months ago by srdjan

Modified:
8 years, 4 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Do not intrinisify closurized functions (they may have different arguments). Fix capacity check. Tested with apidoc.dart. Committed: https://code.google.com/p/dart/source/detail?r=11336

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
M	runtime/vm/intrinsifier.cc	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1 2 3 4 5	4 chunks	+7 lines, -6 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 2 3 4	4 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM