dart2dart Rename statics as globals.

dart2dart Rename statics as globals.

Committed: https://code.google.com/p/dart/source/detail?r=11159

[Roman, 2012-08-22 08:53:37]

Attempt to remove statics as top-level elements.

[Anton Muhin, 2012-08-22 09:05:47]

why we want to rename statics?

Does it make us shadow anything?

[Anton Muhin, 2012-08-22 13:55:51]

lgtm w/ discussed modifications

[Roman, 2012-08-22 14:45:30]

PTAL, I reworked control flow in couple of places.

https://chromiumcodereview.appspot.com/10870008/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart (left):

https://chromiumcodereview.appspot.com/10870008/diff/4001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:56: if
(node.receiver !== null) {
This thing is actually handled with 'if(element.isPrefix)' after visitor goes
deeper.

[Anton Muhin, 2012-08-22 14:58:47]

LGTM!

Very neat reworking of placeholder_collector, less lines, more functionality, I
wish every change would be like that one.

https://chromiumcodereview.appspot.com/10870008/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart (left):

https://chromiumcodereview.appspot.com/10870008/diff/4001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:56: if
(node.receiver !== null) {
On 2012/08/22 14:45:30, Roman wrote:
> This thing is actually handled with 'if(element.isPrefix)' after visitor goes
> deeper.

Nice!

https://chromiumcodereview.appspot.com/10870008/diff/4001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:69:
assert(elements[node.receiver].isPrefix());
why drop assert?

[Roman, 2012-08-22 15:09:03]

https://chromiumcodereview.appspot.com/10870008/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart (left):

https://chromiumcodereview.appspot.com/10870008/diff/4001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:69:
assert(elements[node.receiver].isPrefix());
On 2012/08/22 14:58:47, Anton Muhin wrote:
> why drop assert?

Done.