Issue 10870004: Separate the checks from StoreInstanceField so that they can be eliminated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10870004: Separate the checks from StoreInstanceField so that they can be eliminated. (Closed)

Created:
8 years, 4 months ago by srdjan

Modified:
8 years, 4 months ago

Reviewers:
regis, Florian Schneider

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Separate the checks from StoreInstanceField so that they can be eliminated. Committed: https://code.google.com/p/dart/source/detail?r=11116

Patch Set 6 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -18 lines)			Patch
M	runtime/vm/compiler.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	3 chunks	+19 lines, -9 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4 5	4 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10870004/diff/1005/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://chromiumcodereview.appspot.com/10870004/diff/1005/runtime/vm/intermediate_language.h#newcode1006 runtime/vm/intermediate_language.h:1006: // Set 'original' to NULL if this it ...

8 years, 4 months ago (2012-08-21 23:58:34 UTC) #2

srdjan

8 years, 4 months ago (2012-08-22 00:02:48 UTC) #3

https://chromiumcodereview.appspot.com/10870004/diff/1005/runtime/vm/intermed...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10870004/diff/1005/runtime/vm/intermed...
runtime/vm/intermediate_language.h:1006: // Set 'original' to NULL if this it
cannot deoptimize.
On 2012/08/21 23:58:34, regis wrote:
> if what?

Fixed

Expand Messages | Collapse Messages

Issue 10870004: Separate the checks from StoreInstanceField so that they can be eliminated. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Messages