Issue 10869029: Remove trivially redundant tests from dispatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10869029: Remove trivially redundant tests from dispatch. (Closed)

Created:
8 years, 4 months ago by sra1

Modified:
8 years, 4 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove trivially redundant tests from html_dart2js dispatches. Committed: https://code.google.com/p/dart/source/detail?r=11257

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -99 lines)			Patch
	M	lib/dom/scripts/systemhtml.py	View	1	4 chunks	+15 lines, -10 lines	0 comments	Download
	M	lib/html/dart2js/html_dart2js.dart	View		8 chunks	+18 lines, -89 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 4 months ago (2012-08-23 20:28:09 UTC) #2

LGTM aside from the issue we discussed on named params.

https://chromiumcodereview.appspot.com/10869029/diff/1/lib/html/dart2js/html_...
File lib/html/dart2js/html_dart2js.dart (right):

https://chromiumcodereview.appspot.com/10869029/diff/1/lib/html/dart2js/html_...
lib/html/dart2js/html_dart2js.dart:16887: +    if
((border_OR_canvas_OR_image_OR_pixels_OR_video is ImageElement ||
border_OR_canvas_OR_image_OR_pixels_OR_video == null) &&
You can remove the check on:
border_OR_canvas_OR_image_OR_pixels_OR_video == null
right?  That would be caught in the previous if.  Ditto below.

Expand Messages | Collapse Messages