Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 10869012: Revert "Support sourceing files in patches." (Closed)

Created:
8 years, 4 months ago by Anders Johnsen
Modified:
8 years, 4 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Support sourceing files in patches." This reverts commit f574332325d74c1fe4370496fc5ea212c6f9ac7f. BUG= Committed: https://code.google.com/p/dart/source/detail?r=11145

Patch Set 1 #

Total comments: 2

Patch Set 2 : Re-introduce the refactor in scanner_task. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M lib/compiler/implementation/patch_parser.dart View 1 chunk +1 line, -6 lines 0 comments Download
M lib/compiler/implementation/scanner/scanner_task.dart View 1 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
8 years, 4 months ago (2012-08-22 12:52:31 UTC) #1
ahe
LGTM! https://chromiumcodereview.appspot.com/10869012/diff/1/lib/compiler/implementation/scanner/scanner_task.dart File lib/compiler/implementation/scanner/scanner_task.dart (left): https://chromiumcodereview.appspot.com/10869012/diff/1/lib/compiler/implementation/scanner/scanner_task.dart#oldcode91 lib/compiler/implementation/scanner/scanner_task.dart:91: void sourceTagInLibrary(ScriptTag tag, Uri path, LibraryElement library) { ...
8 years, 4 months ago (2012-08-22 12:55:38 UTC) #2
Anders Johnsen
PTAL https://chromiumcodereview.appspot.com/10869012/diff/1/lib/compiler/implementation/scanner/scanner_task.dart File lib/compiler/implementation/scanner/scanner_task.dart (left): https://chromiumcodereview.appspot.com/10869012/diff/1/lib/compiler/implementation/scanner/scanner_task.dart#oldcode91 lib/compiler/implementation/scanner/scanner_task.dart:91: void sourceTagInLibrary(ScriptTag tag, Uri path, LibraryElement library) { ...
8 years, 4 months ago (2012-08-22 13:03:02 UTC) #3
ahe
8 years, 4 months ago (2012-08-22 13:09:36 UTC) #4
LGTM!

Powered by Google App Engine
This is Rietveld 408576698