Issue 10869011: Make js_interop_1_test pass for none-drt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10869011: Make js_interop_1_test pass for none-drt. (Closed)

Created:
8 years, 4 months ago by Anders Johnsen

Modified:
8 years, 4 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make js_interop_1_test pass for none-drt. BUG= Committed: https://code.google.com/p/dart/source/detail?r=11137

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tests/html/html.status	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

https://chromiumcodereview.appspot.com/10869011/diff/1/tests/html/html.status File tests/html/html.status (right): https://chromiumcodereview.appspot.com/10869011/diff/1/tests/html/html.status#newcode24 tests/html/html.status:24: js_interop_1_test: Pass We should never have a Pass line ...

8 years, 4 months ago (2012-08-22 12:41:02 UTC) #2

Anders Johnsen

8 years, 4 months ago (2012-08-22 12:53:04 UTC) #3

https://chromiumcodereview.appspot.com/10869011/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://chromiumcodereview.appspot.com/10869011/diff/1/tests/html/html.status...
tests/html/html.status:24: js_interop_1_test: Pass
On 2012/08/22 12:41:02, Mads Ager wrote:
> We should never have a Pass line in the status file. Could you guard the Fail
> for this test instead?

Agreed, uploaded here: https://chromiumcodereview.appspot.com/10872012

Expand Messages | Collapse Messages