Retry r11091 with explicit template instatiation to keep the linker happy.

Retry r11091 with explicit template instatiation to keep the linker happy.
Committed: https://code.google.com/p/dart/source/detail?r=11118

[siva, 2012-08-22 00:17:27]

TBR=cshapiro

[cshapiro, 2012-08-22 01:59:20]

lgtm

[Florian Schneider, 2012-08-22 08:18:15]

DBC:

https://chromiumcodereview.appspot.com/10869005/diff/1/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10869005/diff/1/vm/object.cc#newcode1687
vm/object.cc:1687: // Force instantiation of template version to work around ld
problems.
I think explicit instantiation can be avoided if you put the implementation of
template Class::New in the header file. e.g. at the end to avoid cluttering up
the class declaration.

[siva, 2012-08-22 15:17:02]

https://chromiumcodereview.appspot.com/10869005/diff/1/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10869005/diff/1/vm/object.cc#newcode1687
vm/object.cc:1687: // Force instantiation of template version to work around ld
problems.
The function is pretty big and would look pretty odd in the header file not to
mention the potential inlining that may happen resulting in larger code.

This seems to be a problem only in some old versions of 'ld' on linux which the
buildbot is running. I would prefer if we update the build bot machines to a
newer and more saner version of 'ld' so that we don't have to make such weird
code work arounds.

On 2012/08/22 08:18:15, Florian Schneider wrote:
> I think explicit instantiation can be avoided if you put the implementation of
> template Class::New in the header file. e.g. at the end to avoid cluttering up
> the class declaration.