Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 10868105: Fix string unifizationf for dartc. (Closed)

Created:
8 years, 3 months ago by Anders Johnsen
Modified:
8 years, 3 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix string unifizationf for dartc. We don't have to expose string.dart anymore so merge it with string_patch.dart. BUG= Committed: https://code.google.com/p/dart/source/detail?r=11381

Patch Set 1 #

Total comments: 3

Patch Set 2 : Move string.dart to string_base.dart. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -492 lines) Patch
M corelib/src/string.dart View 1 1 chunk +3 lines, -4 lines 0 comments Download
M runtime/lib/lib_impl_sources.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
D runtime/lib/string.dart View 1 chunk +0 lines, -488 lines 0 comments Download
A + runtime/lib/string_base.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
8 years, 3 months ago (2012-08-27 12:52:07 UTC) #1
Mads Ager (google)
Shouldn't you just rename string to string_implementation or something to avoid the overwriting. This is ...
8 years, 3 months ago (2012-08-27 12:55:03 UTC) #2
Anders Johnsen
PTAL https://chromiumcodereview.appspot.com/10868105/diff/1/corelib/src/string.dart File corelib/src/string.dart (right): https://chromiumcodereview.appspot.com/10868105/diff/1/corelib/src/string.dart#newcode11 corelib/src/string.dart:11: interface String extends On 2012/08/27 12:55:03, Mads Ager ...
8 years, 3 months ago (2012-08-27 13:00:24 UTC) #3
Mads Ager (google)
lgtm
8 years, 3 months ago (2012-08-27 13:14:30 UTC) #4
Mads Ager (google)
8 years, 3 months ago (2012-08-27 13:14:30 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698