Throw a runtime error when trying to call a constructor of a class that could not be resolved.

Throw a runtime error when trying to call a constructor of a class that could not be resolved.

TESTS=language/call_constructor_on_unresolved_class_test
BUG=3802
Committed: https://code.google.com/p/dart/source/detail?r=11497

[ngeoffray, 2012-08-24 15:43:48]

https://chromiumcodereview.appspot.com/10868069/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/10868069/diff/2001/lib/compiler/implem...
lib/compiler/implementation/lib/js_helper.dart:777: * exception or it may be a
Dart runtime error which is uncatchable.
Please check with the specification if that's the intent.

https://chromiumcodereview.appspot.com/10868069/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10868069/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2311: visitNewSend(Send node,
Element constructor) {
I'd rather not have this new parameter. The send and the element must be
connected when entering that method, and I prefer that we just fetch the element
out of the node.

https://chromiumcodereview.appspot.com/10868069/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2431: final messageObject = new
DartString.literal(message.toString());
final -> DartString (for consistency)

https://chromiumcodereview.appspot.com/10868069/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2431: final messageObject = new
DartString.literal(message.toString());
message is already a String.

https://chromiumcodereview.appspot.com/10868069/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2462:
compiler.cancel('Unimplemented unresolved constructor call',
Can this still happen?

https://chromiumcodereview.appspot.com/10868069/diff/2001/tests/language/call...
File tests/language/call_constructor_on_unresolvable_class_test.dart (right):

https://chromiumcodereview.appspot.com/10868069/diff/2001/tests/language/call...
tests/language/call_constructor_on_unresolvable_class_test.dart:8: never() =>
false;
This will be inlined and the code below line 12 will be dead code. You should
probably just play with random and make sure you always have false (sra@ made a
lot of these things in the tests/compiler/dart2js_native tests).

[karlklose, 2012-08-28 09:09:15]

PTAL.

https://chromiumcodereview.appspot.com/10868069/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/10868069/diff/2001/lib/compiler/implem...
lib/compiler/implementation/lib/js_helper.dart:777: * exception or it may be a
Dart runtime error which is uncatchable.
Done, changed it to a normal throw.

https://chromiumcodereview.appspot.com/10868069/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10868069/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2311: visitNewSend(Send node,
Element constructor) {
On 2012/08/24 15:43:48, ngeoffray wrote:
> I'd rather not have this new parameter. The send and the element must be
> connected when entering that method, and I prefer that we just fetch the
element
> out of the node.

Done.

https://chromiumcodereview.appspot.com/10868069/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2431: final messageObject = new
DartString.literal(message.toString());
On 2012/08/24 15:43:48, ngeoffray wrote:
> final -> DartString (for consistency)

Done.

https://chromiumcodereview.appspot.com/10868069/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2431: final messageObject = new
DartString.literal(message.toString());
On 2012/08/24 15:43:48, ngeoffray wrote:
> message is already a String.

Done.

https://chromiumcodereview.appspot.com/10868069/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2462:
compiler.cancel('Unimplemented unresolved constructor call',
It should not. I changed it to an internal error saying 'unexpected ...'.

https://chromiumcodereview.appspot.com/10868069/diff/2001/tests/language/call...
File tests/language/call_constructor_on_unresolvable_class_test.dart (right):

https://chromiumcodereview.appspot.com/10868069/diff/2001/tests/language/call...
tests/language/call_constructor_on_unresolvable_class_test.dart:8: never() =>
false;
Done.

[ngeoffray, 2012-08-28 11:44:35]

LGTM!