Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 10868067: dart2js dart:html conversions for serialized script values. (Closed)

Created:
8 years, 4 months ago by sra1
Modified:
8 years, 4 months ago
Reviewers:
vsm, ngeoffray, blois
CC:
reviews_dartlang.org, kasperl, Emily Fortuna
Visibility:
Public.

Description

dart2js dart:html conversions for serialized script values. This fixes issue 1883. Committed: https://code.google.com/p/dart/source/detail?r=11331

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+723 lines, -92 lines) Patch
M lib/dom/scripts/generator.py View 1 chunk +35 lines, -0 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 9 chunks +334 lines, -41 lines 0 comments Download
M lib/html/src/dart2js_Conversions.dart View 5 chunks +315 lines, -32 lines 0 comments Download
M tests/html/html.status View 1 4 chunks +0 lines, -9 lines 0 comments Download
M tests/html/indexeddb_2_test.dart View 2 chunks +30 lines, -9 lines 0 comments Download
M tests/html/utils.dart View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
This change should enable IndexedDB to store structured data. Essentially the same code should be ...
8 years, 4 months ago (2012-08-24 08:11:44 UTC) #1
ngeoffray
JS uses LGTM
8 years, 4 months ago (2012-08-24 08:30:35 UTC) #2
blois
8 years, 4 months ago (2012-08-24 18:26:17 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698