Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 10868058: Add a number of convenience methods to test_pub. (Closed)

Created:
8 years, 4 months ago by nweiz
Modified:
8 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a number of convenience methods to test_pub. This changelist has two goals. The first is to simply clean up pub_test by factoring out repeated patterns, removing the use of raw YAML, and making the commands more semantic. The second goal is to set the stage for the use of ephemeral ports for the mock package server, which will allow multiple instances of the tests to be run simultaneously. This was originally submitted as r11261, but that caused test errors due to a race condition that's fixed in this CL. Committed: https://code.google.com/p/dart/source/detail?r=11266

Patch Set 1 #

Patch Set 2 : Fix race condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -832 lines) Patch
M utils/tests/pub/pub_test.dart View 26 chunks +177 lines, -800 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 1 6 chunks +215 lines, -32 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nweiz
Patch set 1 contains the difference between this and the original CL.
8 years, 4 months ago (2012-08-23 22:21:47 UTC) #1
Bob Nystrom
8 years, 4 months ago (2012-08-23 22:27:14 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698