Issue 10868026: Adding .toggle method to Element.classes to match the JS element.classList.toggle method.

Issue 10868026: Adding .toggle method to Element.classes to match the JS element.classList.toggle method. (Closed)

Created:
8 years, 4 months ago by blois

Modified:
8 years, 3 months ago

Reviewers:
vsm, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding .toggle method to Element.classes to match the JS element.classList.toggle method. BUG=1063 Committed: https://code.google.com/p/dart/source/detail?r=11420

Patch Set 2 : Synchronizing the latest bits #

Patch Set 3 : Patching additional implementations of Element.classes. #

Patch Set 4 : Adding CSSClassSet to wrappers and converting it to a frozen API on DocumentFragment. #

Total comments: 7

Patch Set 5 : Incorporating review feedback. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -29 lines)			Patch
M	lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate	View	1 2 3 4	2 chunks	+13 lines, -2 lines	0 comments	Download
M	lib/dom/templates/html/impl/impl_Element.darttemplate	View	1 2 3 4	4 chunks	+19 lines, -4 lines	0 comments	Download
M	lib/dom/templates/html/impl/impl_SVGElement.darttemplate	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dom/templates/html/interface/interface_Element.darttemplate	View	1 2 3 4	2 chunks	+15 lines, -1 line	0 comments	Download
M	lib/html/dart2js/html_dart2js.dart	View		9 chunks	+48 lines, -8 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		9 chunks	+48 lines, -8 lines	0 comments	Download
M	lib/html/src/DocumentFragmentWrappingImplementation.dart	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/html/src/SVGElementWrappingImplementation.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/src/XMLDocumentWrappingImplementation.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/src/XMLElementWrappingImplementation.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/documentfragment_test.dart	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/html/element_classes_test.dart	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

FYI- I opened bug #4705 to request isFrozen (or equivalent) on collection.

8 years, 4 months ago (2012-08-24 20:18:40 UTC) #1

sra1

DBC https://chromiumcodereview.appspot.com/10868026/diff/6001/lib/dom/templates/html/interface/interface_Element.darttemplate File lib/dom/templates/html/interface/interface_Element.darttemplate (right): https://chromiumcodereview.appspot.com/10868026/diff/6001/lib/dom/templates/html/interface/interface_Element.darttemplate#newcode51 lib/dom/templates/html/interface/interface_Element.darttemplate:51: /// Adds the class to the element if ...

8 years, 4 months ago (2012-08-24 20:31:02 UTC) #2

blois

https://chromiumcodereview.appspot.com/10868026/diff/6001/lib/dom/templates/html/interface/interface_Element.darttemplate File lib/dom/templates/html/interface/interface_Element.darttemplate (right): https://chromiumcodereview.appspot.com/10868026/diff/6001/lib/dom/templates/html/interface/interface_Element.darttemplate#newcode51 lib/dom/templates/html/interface/interface_Element.darttemplate:51: /// Adds the class to the element if it ...

8 years, 4 months ago (2012-08-24 21:39:47 UTC) #3

vsm

8 years, 3 months ago (2012-08-27 19:25:12 UTC) #4

lgtm

I hope we can come up with a plan for getting rid of the specialized subtypes
for Set though.

I also suspect the WrappingImplementation classes are no longer used.  Did you
encounter dependences on them?

Expand Messages | Collapse Messages