Issue 10868020: [dart2dart] In renamer only add import prefix for top-level elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10868020: [dart2dart] In renamer only add import prefix for top-level elements. (Closed)

Created:
8 years, 4 months ago by Roman

Modified:
8 years, 4 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

[dart2dart] In placeholder collector skip non top-level elements from dart:* libraries. Protects us from double-prefixing things like: import('dart:io'); Platform.operatingSystem; Committed: https://code.google.com/p/dart/source/detail?r=11174

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
M	lib/compiler/implementation/dart_backend/placeholder_collector.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/dart_backend/renamer.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/unparser_test.dart	View		4 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages