Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 10867086: Implement array bounds checks explicitly in the optimized IL. (Closed)

Created:
8 years, 3 months ago by Florian Schneider
Modified:
8 years, 3 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement array bounds checks explicitly in the optimized IL. They are inserted by the flow-graph optimizer when specializing array operations. As a result, LoadIndexed and StoreIndexed can't deoptimize themselves anymore. All checks happen before in check-instructions. Redundant array bound checks can be eliminated by CSE if all operands match. Committed: https://code.google.com/p/dart/source/detail?r=11433

Patch Set 1 #

Patch Set 2 : fixed CanDeoptimize() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -69 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 8 chunks +53 lines, -19 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 6 chunks +31 lines, -24 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 6 chunks +31 lines, -24 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Schneider
8 years, 3 months ago (2012-08-27 16:35:27 UTC) #1
srdjan
8 years, 3 months ago (2012-08-27 16:53:52 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698