Issue 10867082: Fix apidoc generation of pkg on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10867082: Fix apidoc generation of pkg on Windows (Closed)

Created:
8 years, 3 months ago by Johnni Winther

Modified:
8 years, 3 months ago

Reviewers:
dgrove, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix apidoc generation of pkg on Windows Committed: https://code.google.com/p/dart/source/detail?r=11431

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	utils/apidoc/apidoc.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm, but I'm surprised that DirectoryLister returns paths that aren't in native form already? It ...

8 years, 3 months ago (2012-08-27 19:40:41 UTC) #2

Jennifer Messerly

8 years, 3 months ago (2012-08-27 23:00:25 UTC) #3

On 2012/08/27 19:40:41, John Messerly wrote:
> lgtm, but I'm surprised that DirectoryLister returns paths that aren't in
native
> form already? It seems like once I give a Path to dart:io, any paths it
creates
> should stay in "normalized form" ... if not, maybe we should rename "new
> Path.fromNative" to "new Path" and do something else with the current
> constructor. This seems like it will be a common mistake.

or DirectoryLister could give you Path objects... that's probably slower though.

Expand Messages | Collapse Messages